Skip to content

Conversation

@scottmarlow
Copy link
Member

…uddy/EnhancerImpl when checking if a class can be enhanced

Signed-off-by: Scott Marlow <[email protected]>
Copy link
Member

@mbellade mbellade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @scottmarlow, looks good to me.

I believe this also solves one of the issues I was trying to fix with #9372, I will rebase and integrate your changes in my PR before merging it (any feedback on that is appreciated, as you were the one to come un with the initial check).

@scottmarlow
Copy link
Member Author

Thank you @scottmarlow, looks good to me.

I believe this also solves one of the issues I was trying to fix with #9372, I will rebase and integrate your changes in my PR before merging it (any feedback on that is appreciated, as you were the one to come un with the initial check).

Thanks @mbladel ! I don't have any concerns. I just noticed the problem while reading the code and there was some discussion in https://hibernate.zulipchat.com/#narrow/channel/132094-hibernate-orm-dev/topic/Hibernate.20ORM.20rules.20for.20property.20accessor.20names.3F as well.

Please do use these changes as you see fit.

@mbellade mbellade merged commit 611fb77 into hibernate:6.6 Dec 9, 2024
30 checks passed
@mbellade
Copy link
Member

mbellade commented Dec 9, 2024

@scottmarlow I've merged your change and ported it to main via #9392, thanks.

For the future, please always open PRs against the main branch: our policy is to do changes in main, and to only cherry-pick what needs to be backported to stable release branches. You can ask within your PR description if you intend for a change to be included in the current maintenance branch, and one of us will backport it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants